Fix thread safety in WaitGroup and add static linkage to memsearch#147
Merged
Conversation
IronsDu
commented
May 25, 2026
IronsDu
commented
Owner
- Add mutex locking to WaitGroup::add() and done() for thread safety
- Only notify when counter reaches zero in done()
- Return bool from timed wait() to indicate success
- Change mCounter from atomic to int (now protected by mutex)
- Add static to memsearch in PromiseReceive for internal linkage
- Add mutex locking to WaitGroup::add() and done() for thread safety - Only notify when counter reaches zero in done() - Return bool from timed wait() to indicate success - Change mCounter from atomic<int> to int (now protected by mutex) - Add static to memsearch in PromiseReceive for internal linkage Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Owner
Author
|
FIx #146 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.